dramaticlly commented on code in PR #13785:
URL: https://github.com/apache/iceberg/pull/13785#discussion_r2283071515
##########
core/src/test/java/org/apache/iceberg/TestMetricsConfig.java:
##########
@@ -28,18 +29,47 @@
public class TestMetricsConfig {
@Test
- public void testNestedStructsRespectedInLimit() {
+ public void testNestedStruct() {
Schema schema =
new Schema(
required(
1,
- "col_struct",
+ "top_struct_a1",
Types.StructType.of(
- required(2, "a", Types.IntegerType.get()),
- required(3, "b", Types.IntegerType.get()))),
- required(4, "top", Types.IntegerType.get()));
+ required(2, "middle_b1", Types.IntegerType.get()),
+ required(
+ 3,
+ "middle_struct_b1",
+ Types.StructType.of(optional(4, "bottom_c1",
Types.StringType.get()))))),
Review Comment:
Sounds great! added in one of struct and corresponding tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
