sungwy commented on code in PR #2255:
URL: https://github.com/apache/iceberg-python/pull/2255#discussion_r2275003377
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1528,22 +1556,64 @@ def _task_to_record_batches(
yield result_batch
-def _read_all_delete_files(io: FileIO, tasks: Iterable[FileScanTask]) ->
Dict[str, List[ChunkedArray]]:
- deletes_per_file: Dict[str, List[ChunkedArray]] = {}
- unique_deletes = set(itertools.chain.from_iterable([task.delete_files for
task in tasks]))
- if len(unique_deletes) > 0:
+def _read_all_delete_files(io: FileIO, tasks: Iterable[FileScanTask]) ->
Union[Dict[str, pa.ChunkedArray], pa.Table]:
Review Comment:
Should this be:
```suggestion
def _read_all_delete_files(io: FileIO, tasks: Iterable[FileScanTask]) ->
Dict[str, List[Union[pa.ChunkedArray, pa.Table]]]:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
