sungwy commented on code in PR #2255:
URL: https://github.com/apache/iceberg-python/pull/2255#discussion_r2274990546
##########
pyiceberg/io/pyarrow.py:
##########
@@ -978,18 +979,23 @@ def _get_file_format(file_format: FileFormat, **kwargs:
Dict[str, Any]) -> ds.Fi
raise ValueError(f"Unsupported file format: {file_format}")
-def _read_deletes(io: FileIO, data_file: DataFile) -> Dict[str,
pa.ChunkedArray]:
+def _read_deletes(io: FileIO, data_file: DataFile) -> Union[Dict[str,
pa.ChunkedArray], pa.Table]:
Review Comment:
I think the output signature and the role of this function is convoluted.
Would it make sense to have two separate functions instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
