rdblue commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2271647099
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -62,7 +63,11 @@ protected BaseFileWriterFactory(
Schema positionDeleteRowSchema) {
this.table = table;
this.dataFileFormat = dataFileFormat;
- this.dataSchema = dataSchema;
+ if (dataSchema != null) {
+ this.dataSchema = PruneUnknownTypes.convert(dataSchema);
Review Comment:
What if we just made `convert` return `null` for a null input? Then this
`if` can be in that method rather than in all the places where it is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
