nastra commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2276138293
##########
orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:
##########
@@ -229,15 +231,26 @@ private static TypeDescription convert(Integer fieldId,
Type type, boolean isReq
Types.ListType list = (Types.ListType) type;
TypeDescription elementType =
convert(list.elementId(), list.elementType(),
list.isElementRequired());
+
+ if (list.elementType().typeId().equals(Type.TypeID.UNKNOWN)) {
Review Comment:
nit: doing the equals the other way around can prevent NPEs, but I guess it
doesn't matter much here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
