rdblue commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2263781326
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -1160,6 +1160,10 @@ public static ListType ofRequired(int elementId, Type
elementType) {
private transient List<NestedField> fields = null;
private ListType(NestedField elementField) {
+ Preconditions.checkArgument(
+ !elementField.type().equals(UnknownType.get()),
+ "Cannot create ListType with unknown type: %s",
+ elementField.name);
Review Comment:
I'm not sure that we should fail here. Can't Avro represent a list of
unknowns using a `NULL` schema?
I would rather fail in the Parquet integration when converting to a Parquet
schema because this is not allowed in Parquet but is fine in Avro or Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
