Fokko commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2265409941


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -1265,6 +1269,10 @@ public static MapType ofRequired(int keyId, int valueId, 
Type keyType, Type valu
     private transient List<NestedField> fields = null;
 
     private MapType(NestedField keyField, NestedField valueField) {
+      Preconditions.checkArgument(

Review Comment:
   Yes, the when initializing a `MapType` with an `UnknownType` as the key, it 
will throw right away because the key has to be required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to