zeroshade commented on code in PR #495:
URL: https://github.com/apache/iceberg-go/pull/495#discussion_r2255216459
##########
table/arrow_utils.go:
##########
@@ -1287,9 +1294,12 @@ func recordsToDataFiles(ctx context.Context,
rootLocation string, meta *Metadata
if err != nil {
panic(err)
}
-
+ currentSpec, err := meta.CurrentSpec()
+ if err != nil || currentSpec == nil {
+ panic(fmt.Errorf("%w: cannot write files without a current
spec", err))
+ }
nextCount, stopCount := iter.Pull(args.counter)
- if meta.CurrentSpec().IsUnpartitioned() {
+ if (*currentSpec).IsUnpartitioned() {
Review Comment:
you shouldn't need the `*`, right? Go `.` should automatically handle that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
