twuebi commented on code in PR #495:
URL: https://github.com/apache/iceberg-go/pull/495#discussion_r2235939163
##########
table/metadata.go:
##########
@@ -149,7 +149,7 @@ type MetadataBuilder struct {
schemaList []*iceberg.Schema
currentSchemaID int
specs []iceberg.PartitionSpec
- defaultSpecID int
+ defaultSpecID *int
Review Comment:
Given the absence of an Option type in Go and the validity of a 0 for
defaultSpecID, I felt that making it nullable will help us differentiate
between unset / set to 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
