zeroshade commented on code in PR #495:
URL: https://github.com/apache/iceberg-go/pull/495#discussion_r2255140005
##########
table/metadata.go:
##########
@@ -215,6 +218,7 @@ func MetadataBuilderFromBase(metadata Metadata)
(*MetadataBuilder, error) {
func (b *MetadataBuilder) HasChanges() bool { return len(b.updates) > 0 }
func (b *MetadataBuilder) CurrentSpec() iceberg.PartitionSpec {
+ // FIXME: this should return a pointer which can be nil to avoid out of
bounds indexing / np derefs
return b.specs[b.defaultSpecID]
Review Comment:
can we fix this now instead of leaving the `FIXME`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
