kevinjqliu commented on code in PR #2251: URL: https://github.com/apache/iceberg-python/pull/2251#discussion_r2249453227
########## mkdocs/docs/configuration.md: ########## @@ -105,6 +105,33 @@ You can also set the FileIO explicitly: For the FileIO there are several configuration options available: +### PyArrow FileSystem Extra Properties Review Comment: This looks great! nit: can we move this to after end of the `FileIO` section? maybe within the `Pyarrow` subsection? <img width="1054" height="569" alt="Screenshot 2025-08-02 at 4 05 09 PM" src="https://github.com/user-attachments/assets/e863ebef-c2c4-4569-baae-5c3a4d0a0c24"; /> ########## pyiceberg/io/pyarrow.py: ########## @@ -397,6 +411,32 @@ def parse_location(location: str) -> Tuple[str, str, str]: else: return uri.scheme, uri.netloc, f"{uri.netloc}{uri.path}" + def _process_basic_properties( Review Comment: i was playing around refactoring this over the weekend. could you take a look at https://github.com/kevinjqliu/iceberg-python/pull/17? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
