Fokko commented on PR #2251: URL: https://github.com/apache/iceberg-python/pull/2251#issuecomment-3156093949
Sorry for jumping in so late here, I was out touching grass. While I see what we're trying to achieve here, and provide flexibility to the user, I think it comes at a cost. First of all, the most obivous one; it creates multiple paths to set the same configuration, which might be confusing for new users. That said, the intended of allow-listing the configuration is an effort to consolidate the configuration accross implementations, but also across FileIO's. For example, `s3.connect-timeout` and `s3.request-timeout` is picked up both by fsspec and PyArrow. This avoids having to go though the documentation of each of the underlying implementation, or in the case of PyArrow, through the source code :D I think the main question here is, to what extend we want to try to hide the implementation behind the FileIO, or do we want to expose the implementation details to the end-users. I'm leaning towards the first, but curious what others' think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
