kevinjqliu commented on PR #2251: URL: https://github.com/apache/iceberg-python/pull/2251#issuecomment-3133076832
Thank you for the PR! This is a great way to unblock end users from configuring the different file systems. Instead of allowlisting each property individually, for each file system implementation constructor, this will allow us to pass args to the file system constructor. We should verify that the implementation does not conflict with existing properties. For example, `s3.access-key-id` can now also be passed in as `access_key` in [S3FileSystem](https://arrow.apache.org/docs/python/generated/pyarrow.fs.S3FileSystem.html) but we should prioritize `s3.access-key-id` https://github.com/apache/iceberg/blob/571056929091f1e62412500045f71e5ba6ea00ad/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java#L249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
