nastra commented on code in PR #13718:
URL: https://github.com/apache/iceberg/pull/13718#discussion_r2251171168
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3V4RestSignerClient.java:
##########
@@ -133,6 +150,18 @@ public static Stream<Arguments> validOAuth2Properties() {
"token",
OAuth2Properties.CREDENTIAL,
"user:12345"),
+ "token"),
+ // Custom scope
+ Arguments.of(
+ Map.of(
+ S3_SIGNER_URI,
+ "https://signer.com";,
+ AuthProperties.AUTH_TYPE,
+ AuthProperties.AUTH_TYPE_OAUTH2,
+ OAuth2Properties.CREDENTIAL,
+ "user:12345",
+ OAuth2Properties.SCOPE,
+ "custom"),
Review Comment:
can we have a test that verifies that the default scope is `sign` when no
custom scope is defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
