adutra commented on code in PR #13718:
URL: https://github.com/apache/iceberg/pull/13718#discussion_r2248054934
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3V4RestSignerClient.java:
##########
@@ -59,7 +59,24 @@ static void beforeAll() {
"client_secret",
"12345",
"scope",
- "sign")),
+ "catalog")),
Review Comment:
I manually validated this against pre-AuthManager code: the scope is in fact
never `sign`. It's
`catalog` by default, unless overridden by the user.
This happens because there is _always_ a scope included in
`optionalOAuthParams()`:
https://github.com/apache/iceberg/blob/67e181ea9b706afc8ff9d1bcd0f9e9c240f173cd/core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java#L140-L142
This test is new and was wrong when I created it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
