adutra commented on code in PR #13718:
URL: https://github.com/apache/iceberg/pull/13718#discussion_r2248457552
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -166,10 +166,10 @@ AuthSession authSession() {
ImmutableMap.Builder<String, String> properties =
ImmutableMap.<String, String>builder()
.putAll(properties())
- .putAll(optionalOAuthParams())
.put(OAuth2Properties.OAUTH2_SERVER_URI, oauth2ServerUri())
.put(OAuth2Properties.TOKEN_REFRESH_ENABLED,
String.valueOf(keepTokenRefreshed()))
- .put(OAuth2Properties.SCOPE, SCOPE);
+ .put(OAuth2Properties.SCOPE, SCOPE)
Review Comment:
The call to `.put(OAuth2Properties.SCOPE, SCOPE)` here is imo useless since
the scope will be overridden by `.putAll(optionalOAuthParams())` – but it
doesn't hurt to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
