singhpk234 commented on code in PR #13716:
URL: https://github.com/apache/iceberg/pull/13716#discussion_r2248602280
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -992,6 +992,24 @@ private FileIO newFileIO(
}
}
+ private FileIO tableFileIO(
+ SessionContext context,
+ TableIdentifier identifier,
+ Map<String, String> config,
+ List<Credential> storageCredentials) {
+ // inject the credentials refresh endpoint if, refresh is configured
+ // TODO: convert this to constants.
+ boolean refreshEnabled =
+ PropertyUtil.propertyAsBoolean(config,
"client.refresh-credentials-enabled", false);
Review Comment:
Thank you so much for the feedbacks @nastra !
I agree, i think we already these eq properties for ADLS
https://github.com/apache/iceberg/pull/11577 , let me check if i can add it in
GCP ?
> Also what if the refresh endpoint has been provided by the server in the
config?
How about if it provided from server, respect that, else if client property
just say's client-refresh.enabled than create it in the client end, mostly
comming from the perpective that server doesnot know the complete uri, only
client does and the client-refresh-endpoint expects the absolute uri and even
if we pass a relative uri that uril for a table is more or less fixed, so
essentially this whole boils down to if a server supports cred refresh endpoint
which imho in `/v1/config` it has already indicated.
The main problem i think is the following :
- table level creds endpoint and server doesn't know full uri
can we just make the server return `refresh enabled` then ? so that the
client creates the uri at its end ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
