nastra commented on code in PR #13716:
URL: https://github.com/apache/iceberg/pull/13716#discussion_r2251129791
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -992,6 +992,38 @@ private FileIO newFileIO(
}
}
+ private FileIO tableFileIO(
+ SessionContext context,
+ TableIdentifier identifier,
+ Map<String, String> config,
+ List<Credential> storageCredentials) {
+ // Check if either credential refresh is enabled from either client side
or server side.
+ // TODO: convert this to constants.
+ boolean s3RefreshEnabled =
Review Comment:
I think the issue here is that we're "leaking" storage-specific settings
into the REST layer, which we typically want to avoid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
