nastra commented on code in PR #13716:
URL: https://github.com/apache/iceberg/pull/13716#discussion_r2247281339
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -992,6 +992,24 @@ private FileIO newFileIO(
}
}
+ private FileIO tableFileIO(
+ SessionContext context,
+ TableIdentifier identifier,
+ Map<String, String> config,
+ List<Credential> storageCredentials) {
+ // inject the credentials refresh endpoint if, refresh is configured
+ // TODO: convert this to constants.
+ boolean refreshEnabled =
+ PropertyUtil.propertyAsBoolean(config,
"client.refresh-credentials-enabled", false);
Review Comment:
these properties are specific to S3, so they would only work with S3 not and
with GCS/ADLS. Also what if the refresh endpoint has been provided by the
server in the config?
The thing is that only the server would know for which kind of storage type
it vended the credentials for a particular table and so the server would have
to send back the respective "refresh enabled" and "refresh endpoint" properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
