amogh-jahagirdar commented on code in PR #13310:
URL: https://github.com/apache/iceberg/pull/13310#discussion_r2193601358
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -736,7 +769,14 @@ public void update(InternalRow meta, InternalRow id,
InternalRow row) throws IOE
@Override
public void insert(InternalRow row) throws IOException {
- delegate.insert(row, dataSpec, null);
+ reinsert(null, row);
+ }
+
+ @Override
+ public void reinsert(InternalRow meta, InternalRow row) throws IOException
{
Review Comment:
You're right I was also looking at how we can just project fields from a row
without copying the specific fields again, and I saw this pattern too. I will
incorporate this in my next update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
