stevenzwu commented on code in PR #13310: URL: https://github.com/apache/iceberg/pull/13310#discussion_r2193459841
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineageFromMetadata.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source; + +import java.util.function.Function; +import org.apache.iceberg.MetadataColumns; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.catalyst.ProjectingInternalRow; +import org.apache.spark.sql.catalyst.expressions.GenericInternalRow; + +class ExtractRowLineageFromMetadata implements Function<InternalRow, InternalRow> { + private Integer rowIdOrdinal; + private Integer lastUpdatedOrdinal; + + @Override + public InternalRow apply(InternalRow meta) { + GenericInternalRow row = new GenericInternalRow(2); Review Comment: I think this can work as the wrapper/projection pattern, like `StructProjection`, `InternalRowWrapper`, `StructInternalRow`. Here is what I am thinking ``` class RowLineageProjection extends InternalRow { RowLineageProjection(StructType rowSchema); public void project(InternalRow row); @Override public long getLong(int ordinal) } ``` Or we can have a generic `InternalRowProjection`, similar to `RowDataProjection` in the Flink module. ``` class InternalRowProjection extends InternalRow { InternalRowProjection(StructType rowSchema, StructType projectedSchema); public void project(InternalRow row); // ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
