MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2191734291
########## src/iceberg/avro/avro_schema_util_internal.h: ########## @@ -144,4 +145,39 @@ std::string ToString(const ::avro::LogicalType::Type& logical_type); /// \return True if the node has a map logical type, false otherwise. bool HasMapLogicalType(const ::avro::NodePtr& node); +/// \brief Create a new Avro node with field IDs from name mapping. +/// \param original_node The original Avro node to copy. +/// \param name_mapping The name mapping to apply field IDs from. +/// \return A new Avro node with field IDs applied, or an error. +Result<::avro::NodePtr> CreateAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, Review Comment: ApplyNameMapping is delete, now I use CreateAvroNodeWithFieldIds to create new record node, because ApplyNameMapping have an ambiguity, we need to create new avro node, not apply in original avro record node. I will move other function internal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org