wgtmac commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2220891400
########## src/iceberg/avro/avro_schema_util_internal.h: ########## @@ -144,4 +145,18 @@ std::string ToString(const ::avro::LogicalType::Type& logical_type); /// \return True if the node has a map logical type, false otherwise. bool HasMapLogicalType(const ::avro::NodePtr& node); +/// \brief Create a new Avro node with field IDs from name mapping. +/// \param original_node The original Avro node to copy. +/// \param mapped_field The mapped field to apply field IDs from. +/// \return A new Avro node with field IDs applied, or an error. +Result<::avro::NodePtr> CreateAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, Review Comment: We usually use `Make` instead of `Create` as the convention... ########## src/iceberg/avro/avro_schema_util_internal.h: ########## @@ -144,4 +145,18 @@ std::string ToString(const ::avro::LogicalType::Type& logical_type); /// \return True if the node has a map logical type, false otherwise. bool HasMapLogicalType(const ::avro::NodePtr& node); +/// \brief Create a new Avro node with field IDs from name mapping. +/// \param original_node The original Avro node to copy. +/// \param mapped_field The mapped field to apply field IDs from. +/// \return A new Avro node with field IDs applied, or an error. +Result<::avro::NodePtr> CreateAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, + const MappedField& mapped_field); + +/// \brief Create a new Avro node with field IDs from name mapping. +/// \param original_node The original Avro node to copy. +/// \param mapping The name mapping to apply field IDs from. +/// \return A new Avro node with field IDs applied, or an error. +Result<::avro::NodePtr> CreateAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, Review Comment: ```suggestion Result<::avro::NodePtr> MakeAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, ``` ########## src/iceberg/avro/avro_schema_util_internal.h: ########## @@ -144,4 +145,18 @@ std::string ToString(const ::avro::LogicalType::Type& logical_type); /// \return True if the node has a map logical type, false otherwise. bool HasMapLogicalType(const ::avro::NodePtr& node); +/// \brief Create a new Avro node with field IDs from name mapping. +/// \param original_node The original Avro node to copy. +/// \param mapped_field The mapped field to apply field IDs from. +/// \return A new Avro node with field IDs applied, or an error. +Result<::avro::NodePtr> CreateAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, Review Comment: ```suggestion Result<::avro::NodePtr> MakeAvroNodeWithFieldIds(const ::avro::NodePtr& original_node, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
