rambleraptor commented on code in PR #1482: URL: https://github.com/apache/iceberg-rust/pull/1482#discussion_r2190851276
########## crates/iceberg/src/avro/schema.rs: ########## @@ -43,6 +43,41 @@ const MAP_LOGICAL_TYPE: &str = "map"; // This const may better to maintain in avro-rs. const LOGICAL_TYPE: &str = "logicalType"; +fn literal_to_json(literal: &crate::spec::Literal) -> Result<Value> { Review Comment: My Rust-foo is failing me at the moment. What's the best way to convert this from a Literal -> Datum in order to serialize it? It seems like we're doing a conversion to JSON no matter what? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org