Re: [PR] Read ManifestList V1 with V2 projection. [iceberg-rust]

[via GitHub]

rambleraptor commented on code in PR #1482:
URL: https://github.com/apache/iceberg-rust/pull/1482#discussion_r2181119283


##########
crates/iceberg/src/spec/manifest/entry.rs:
##########
@@ -563,6 +563,16 @@ pub(super) fn manifest_schema_v2(partition_type: 
&StructType) -> Result<AvroSche
 
 fn data_file_fields_v1(partition_type: &StructType) -> Vec<NestedFieldRef> {
     vec![
+        // Content is always 1.
+        Arc::new(NestedField::builder()
+            .id(134)
+            .name("content")
+            .required(false)
+            .field_type(Type::Primitive(PrimitiveType::Int))
+            .initial_default(Some(serde_json::Value::Number(1.into())))
+            .write_default(Some(serde_json::Value::Number(1.into())))
+            .build()
+        ),

Review Comment:
   Ah, I understand now! Thanks a lot. Made that change + added a round trip.
   
   There does appear to be some missing logic around `initial_default`. I added 
it in and it doesn't appear to be breaking the test suite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org