liurenjie1024 commented on code in PR #1482: URL: https://github.com/apache/iceberg-rust/pull/1482#discussion_r2189513778
########## crates/iceberg/src/avro/schema.rs: ########## @@ -43,6 +43,41 @@ const MAP_LOGICAL_TYPE: &str = "map"; // This const may better to maintain in avro-rs. const LOGICAL_TYPE: &str = "logicalType"; +fn literal_to_json(literal: &crate::spec::Literal) -> Result<Value> { Review Comment: We should not add this method, there exists a serialization method for `Datum`: https://github.com/apache/iceberg-rust/blob/c74a27ac0d77314926240d325701107e5360f836/crates/iceberg/src/spec/values.rs#L114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org