nastra commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2164085370


##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -136,6 +137,14 @@ public String toString() {
 
   protected abstract String defaultWarehouseLocation(TableIdentifier 
tableIdentifier);
 
+  protected String formatTableName(TableIdentifier table, boolean 
uniqueTableLocation) {

Review Comment:
   maybe this should go into `LocationUtil` to better indicate that this is 
about "locations". At the very least we should find a better name, since 
`format` is rather misleading



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to