aiborodin commented on code in PR #13340:
URL: https://github.com/apache/iceberg/pull/13340#discussion_r2160793599
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java:
##########
@@ -47,16 +48,24 @@ class TableMetadataCache {
private static final int MAX_SCHEMA_COMPARISON_RESULTS_TO_CACHE = 10;
private static final Tuple2<Boolean, Exception> EXISTS = Tuple2.of(true,
null);
private static final Tuple2<Boolean, Exception> NOT_EXISTS =
Tuple2.of(false, null);
- static final Tuple2<Schema, CompareSchemasVisitor.Result> NOT_FOUND =
- Tuple2.of(null, CompareSchemasVisitor.Result.SCHEMA_UPDATE_NEEDED);
+ static final SchemaCompareInfo NOT_FOUND =
+ new SchemaCompareInfo(
+ null, CompareSchemasVisitor.Result.SCHEMA_UPDATE_NEEDED,
DataConverter.identity());
private final Catalog catalog;
private final long refreshMs;
+ private final int inputSchemasPerTableCacheMaximumSize;
private final Cache<TableIdentifier, CacheItem> cache;
TableMetadataCache(Catalog catalog, int maximumSize, long refreshMs) {
+ this(catalog, maximumSize, refreshMs,
MAX_SCHEMA_COMPARISON_RESULTS_TO_CACHE);
+ }
Review Comment:
Acknowledged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
