mxm commented on code in PR #13340:
URL: https://github.com/apache/iceberg/pull/13340#discussion_r2163254068
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java:
##########
@@ -220,37 +238,59 @@ SchemaInfo getSchemaInfo() {
*/
static class SchemaInfo {
private final Map<Integer, Schema> schemas;
- private final Map<Schema, Tuple2<Schema, CompareSchemasVisitor.Result>>
lastResults;
+ private final Cache<Schema, SchemaCompareInfo> lastResults;
Review Comment:
>Could you run the test to compare the LinkedList with the cache
implementation. I see that there is a slight ~2% degradation in performance
with this PR applied. It would be interesting to see if the cause of this
change is the Cache, or there is another source?
That's what I did. "Status quo" refers to the main branch. There is a slight
overhead, but it is very marginal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
