pvary commented on code in PR #13340:
URL: https://github.com/apache/iceberg/pull/13340#discussion_r2159194016
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -315,6 +316,16 @@ public Builder<T> cacheRefreshMs(long refreshMs) {
return this;
}
+ /**
+ * Maximum input {@link org.apache.iceberg.Schema} objects to cache per
each Iceberg table. The
+ * cache improves Dynamic Sink performance by storing {@link
org.apache.iceberg.Schema}
+ * comparison results.
+ */
+ public Builder<T> inputSchemasPerTableCacheMaxSize(int
inputSchemasPerTableCacheMaximumSize) {
+ this.inputSchemasPerTableCacheMaximumSize =
inputSchemasPerTableCacheMaximumSize;
+ return this;
+ }
+
Review Comment:
We are more conservative about the possible configuration options. I would
suggest to refrain from introducing a new config until we know how we would
like to do it. Otherwise we need to keep the old one for backward compatibility
reasons.
If we are not sure we can start with some reasonable static value, and add
the config later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
