RussellSpitzer commented on code in PR #13339:
URL: https://github.com/apache/iceberg/pull/13339#discussion_r2155002116
##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -507,13 +546,18 @@ public static void testHttpMethodOnFailure(HttpMethod
method) throws JsonProcess
// it.
private static String addRequestTestCaseAndGetPath(HttpMethod method, Item
body, int statusCode)
throws JsonProcessingException {
-
- // Build the path route, which must be unique per test case.
boolean isSuccess = statusCode == 200;
// Using different paths keeps the expectations unique for the test's mock
server
String pathName = isSuccess ? "success" : "failure";
String path = String.format("%s_%s", method, pathName);
+ return TestHTTPClient.addRequestTestCaseAndGetPath(path, method, body,
statusCode);
Review Comment:
Could this be addRequestTestCaseAndGetPath without the class name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
