sfc-gh-rxing commented on code in PR #13339: URL: https://github.com/apache/iceberg/pull/13339#discussion_r2153649099
########## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ########## @@ -233,7 +233,7 @@ private static void throwFailure( ErrorResponse enrichedErrorResponse = ErrorResponse.builder() - .wasRetried(wasRetried == Boolean.TRUE) + .wasRetried(Boolean.TRUE.equals(wasRetried)) Review Comment: It's not required, I just got used to using `equals` after seeing some static analysis warnings. Using `==` may not pass certain checks, even though it's safe here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org