XJDKC commented on code in PR #13339:
URL: https://github.com/apache/iceberg/pull/13339#discussion_r2155143065


##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -507,13 +546,18 @@ public static void testHttpMethodOnFailure(HttpMethod 
method) throws JsonProcess
   // it.
   private static String addRequestTestCaseAndGetPath(HttpMethod method, Item 
body, int statusCode)

Review Comment:
   Updated the doc, I'll address this more thoroughly in the follow-up 
refactoring.
   
   In most cases, we should return a consistent response. However, for retry 
scenarios, we may need finer control over the responses across retries. For 
example, it may make sense for the final mock request in a retry sequence to 
return a fixed, constant response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to