zeroshade commented on code in PR #454:
URL: https://github.com/apache/iceberg-go/pull/454#discussion_r2153181812
##########
io/gcs.go:
##########
@@ -46,6 +49,9 @@ func ParseGCSConfig(props map[string]string) *gcsblob.Options
{
if path := props[GCSKeyPath]; path != "" {
o = append(o, option.WithCredentialsFile(path))
}
+ if _, ok := props[GCSUseJsonAPI]; ok {
+ o = append(o, storage.WithJSONReads())
+ }
Review Comment:
is this the only reason why we're pulling in `cloud.google.com/go/storage`?
I think that's okay for now, but we may want to see if we potentially
contribute to `gocloud.dev/gcp` instead of pulling an entire other library in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
