laskoviymishka commented on code in PR #454:
URL: https://github.com/apache/iceberg-go/pull/454#discussion_r2129700365
##########
io/gcs.go:
##########
@@ -55,7 +55,16 @@ func ParseGCSConfig(props map[string]string)
*gcsblob.Options {
// Construct a GCS bucket from a URL
func createGCSBucket(ctx context.Context, parsed *url.URL, props
map[string]string) (*blob.Bucket, error) {
gcscfg := ParseGCSConfig(props)
- client := gcp.NewAnonymousHTTPClient(gcp.DefaultTransport())
+ creds, err := gcp.DefaultCredentials(ctx) // or use
service-account JSON
Review Comment:
can you elaborate how this would work?
how we alter creds to service account here? is this something like magic
env-vars?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
