himadripal commented on code in PR #13167:
URL: https://github.com/apache/iceberg/pull/13167#discussion_r2144036757
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/functions/BucketFunction.java:
##########
@@ -128,6 +133,23 @@ public String name() {
public DataType resultType() {
return DataTypes.IntegerType;
}
+
+ public int gcd(int num1, int num2) {
Review Comment:
I think we can not rename to just a and b, build fails with checkstyle error
Error: eckstyle] [ERROR]
/home/runner/work/iceberg/iceberg/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/functions/BucketFunction.java:137:27:
Name 'a' must match pattern '^[a-z][a-zA-Z0-9]++$'. [ParameterName]
Error: eckstyle] [ERROR]
/home/runner/work/iceberg/iceberg/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/functions/BucketFunction.java:137:34:
Name 'b' must match pattern '^[a-z][a-zA-Z0-9]++$'. [ParameterName]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
