huaxingao commented on PR #13167: URL: https://github.com/apache/iceberg/pull/13167#issuecomment-2921381421
Thanks @himadripal for the PR — it looks good overall. I've left a few minor comments. Could you please update the PR description to briefly explain the purpose of this change? Additionally, maybe also consider adding a test case to cover the scenario where reducer(...) returns null when thisNumBuckets == GCD — this would help ensure the no-op reducer path is exercised as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
