himadripal commented on code in PR #13167:
URL: https://github.com/apache/iceberg/pull/13167#discussion_r2143812151
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/functions/BucketFunction.java:
##########
@@ -128,6 +133,23 @@ public String name() {
public DataType resultType() {
return DataTypes.IntegerType;
}
+
+ public int gcd(int num1, int num2) {
+ return
BigInteger.valueOf(num1).gcd(BigInteger.valueOf(num2)).intValueExact();
Review Comment:
Because we are converting to BigInteger, we would need to convert back to
intValue, other method is intValue alone which does not throw Arithmetic
exception in case of overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
