Smith-Cruise commented on PR #121: URL: https://github.com/apache/iceberg-cpp/pull/121#issuecomment-2961865856
> Generally I think the logic with `PartitionFieldFromJson(json, /*allow_field_id_missing=*/true)` and current logic is equal, but this LGTM. Also cc @wgtmac Just ensure that `field_id` is always valid when PartitionField is created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
