mapleFU commented on code in PR #121:
URL: https://github.com/apache/iceberg-cpp/pull/121#discussion_r2137433518
##########
src/iceberg/json_internal.cc:
##########
@@ -1053,7 +1053,7 @@ Status ParsePartitionSpecs(const nlohmann::json& json,
int8_t format_version,
int32_t next_partition_field_id =
PartitionSpec::kLegacyPartitionDataIdStart;
std::vector<PartitionField> fields;
for (const auto& entry_json : partition_spec_json) {
- ICEBERG_ASSIGN_OR_RAISE(auto field, PartitionFieldFromJson(entry_json));
+ ICEBERG_ASSIGN_OR_RAISE(auto field, PartitionFieldFromJson(entry_json,
true));
Review Comment:
( can we use something like code below?)
```c++
ICEBERG_ASSIGN_OR_RAISE(auto field, PartitionFieldFromJson(entry_json,
/*allow_field_id_missing=*/format_version==1));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
