Smith-Cruise commented on PR #121: URL: https://github.com/apache/iceberg-cpp/pull/121#issuecomment-2958810236
> https://github.com/apache/iceberg/blob/7b8bd29ce80bc78ed882f0613f7570e78e325988/core/src/main/java/org/apache/iceberg/PartitionSpecParser.java#L137-L144 Your idea is correct. I think I can change signature to `PartitionFieldFromJson(const nlohmann::json& json, std::optional<int32_t> next_partition_field_id)`. if next_partition_field_id has value, we assign field_id from `next_partition_field_id` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
