RussellSpitzer commented on code in PR #13284:
URL: https://github.com/apache/iceberg/pull/13284#discussion_r2138555098
##########
core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java:
##########
@@ -111,10 +113,13 @@ public int sizeInBytes() {
case BINARY:
return 5 + ((ByteBuffer) value).remaining(); // 1 header + 4 length +
value length
case STRING:
+ byte[] valueBytes = ((String) value).getBytes(StandardCharsets.UTF_8);
if (null == buffer) {
- this.buffer = ByteBuffer.wrap(((String)
value).getBytes(StandardCharsets.UTF_8));
+ this.buffer = ByteBuffer.wrap(valueBytes);
+ }
+ if (valueBytes.length < SHORT_STRING_LENGTH) {
+ return 1 + buffer.remaining(); // 1 header + 1 length + value length
Review Comment:
Comment here is wrong, the length and header are encoded in the same byte
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
