RussellSpitzer commented on code in PR #13284: URL: https://github.com/apache/iceberg/pull/13284#discussion_r2138503201
########## core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java: ########## @@ -53,6 +53,8 @@ class PrimitiveWrapper<T> implements VariantPrimitive<T> { private static final byte TIMESTAMPNTZ_NANOS_HEADER = VariantUtil.primitiveHeader(Primitives.TYPE_TIMESTAMPNTZ_NANOS); private static final byte UUID_HEADER = VariantUtil.primitiveHeader(Primitives.TYPE_UUID); + private static final int SHORT_STRING_LENGTH = 64; Review Comment: Nit: MAX_SHORT_STRING_LENGTH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org