RussellSpitzer commented on code in PR #13284:
URL: https://github.com/apache/iceberg/pull/13284#discussion_r2143355126
##########
api/src/test/java/org/apache/iceberg/variants/VariantTestUtil.java:
##########
@@ -107,6 +121,15 @@ static SerializedPrimitive createString(String string) {
return SerializedPrimitive.from(buffer, buffer.get(0));
}
+ /** Creates a short string primitive of max 63 chars to use only 1 header */
+ static SerializedShortString createShortString(String string) {
+ byte[] utf8 = string.getBytes(StandardCharsets.UTF_8);
Review Comment:
I would put a precondition in here to make sure no one uses this test method
with a string of longer than 63 bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
