himadripal commented on code in PR #13166: URL: https://github.com/apache/iceberg/pull/13166#discussion_r2122410657
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/functions/DaysFunction.java: ########## @@ -70,6 +73,11 @@ public String name() { public DataType resultType() { return DataTypes.DateType; } + + @Override + public Reducer<Integer, Integer> reducer(ReducibleFunction<?, ?> otherFunction) { Review Comment: there is a check in reducing process whether the both side of the function is ReducibleFunction or not. To pass that check it is required to implement ReducibleFunction. Eventually with subsequent PR for Days to Months we need to implement this and have a return null in MonthFunc. I tried default implementation as super.reducer but it throws incompatible error coming from default spark reducer implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org