huaxingao commented on code in PR #13166:
URL: https://github.com/apache/iceberg/pull/13166#discussion_r2118340552
##########
api/src/main/java/org/apache/iceberg/util/DateTimeUtil.java:
##########
@@ -183,6 +183,11 @@ public static long isoTimestampToNanos(CharSequence
timestampString) {
LocalDateTime.parse(timestampString,
DateTimeFormatter.ISO_LOCAL_DATE_TIME));
}
+ public static int hoursToDays(int hours) {
Review Comment:
Shall we add a unit test to validate this method explicitly? SPJ-level join
tests confirm overall correctness and shuffle behavior, but they could still
pass even if this method has a subtle bug. A direct test would help catch edge
cases more reliably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
