szehon-ho commented on code in PR #13166:
URL: https://github.com/apache/iceberg/pull/13166#discussion_r2122404958
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##########
@@ -578,6 +584,62 @@ public void testAggregates() throws NoSuchTableException {
tableName(OTHER_TABLE_NAME));
}
+ @TestTemplate
+ public void testJoinsHourToDays() throws NoSuchTableException {
+ String createTableStmt =
+ "CREATE TABLE %s ("
+ + "id BIGINT, int_col INT,dep STRING,timestamp_col TIMESTAMP) "
+ + "USING iceberg "
+ + "PARTITIONED BY (days(timestamp_col)) "
+ + "TBLPROPERTIES (%s)";
+
+ sql(createTableStmt, tableName, tablePropsAsString(TABLE_PROPERTIES));
+
+ sql("INSERT INTO %s VALUES (1L, 100, 'software', TIMESTAMP('2024-11-11
10:00:00'))", tableName);
Review Comment:
same, i would make this into one insert to save test time
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/functions/DaysFunction.java:
##########
@@ -70,6 +73,11 @@ public String name() {
public DataType resultType() {
return DataTypes.DateType;
}
+
+ @Override
+ public Reducer<Integer, Integer> reducer(ReducibleFunction<?, ?>
otherFunction) {
Review Comment:
is there a point to implementing ReducibleFunction here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
