Erigara commented on PR #1395: URL: https://github.com/apache/iceberg-rust/pull/1395#issuecomment-2923146110
I changed my initial implementation so that DELETED manifest entries are skipped. Which is in line with pyiceberg behavior: - https://github.com/apache/iceberg-python/blob/3070e7a2b8d681cd02f753b3a46e6ff1b27b76cf/pyiceberg/table/__init__.py#L835 - https://github.com/apache/iceberg-python/blob/3070e7a2b8d681cd02f753b3a46e6ff1b27b76cf/pyiceberg/table/inspect.py#L660 - https://github.com/apache/iceberg-python/blob/3070e7a2b8d681cd02f753b3a46e6ff1b27b76cf/pyiceberg/table/inspect.py#L655 - https://github.com/apache/iceberg-python/blob/3070e7a2b8d681cd02f753b3a46e6ff1b27b76cf/pyiceberg/table/inspect.py#L535 - https://github.com/apache/iceberg-python/blob/3070e7a2b8d681cd02f753b3a46e6ff1b27b76cf/pyiceberg/manifest.py#L717 - here you can see that DELETED entries are skipped -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
