liurenjie1024 commented on code in PR #1395:
URL: https://github.com/apache/iceberg-rust/pull/1395#discussion_r2131969944
##########
crates/integration_tests/tests/shared_tests/append_data_file_test.rs:
##########
@@ -132,7 +132,10 @@ async fn test_append_data_file() {
// commit result again
let tx = Transaction::new(&table);
- let mut append_action = tx.fast_append(None, vec![]).unwrap();
+ let mut append_action = tx
+ .fast_append(None, vec![])
+ .unwrap()
+ .with_check_duplicate(false);
Review Comment:
Why we need this? I think if there exists duplicated files in this test, we
should remove it.
##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -379,6 +364,7 @@ mod tests {
// Attempt to add the existing Parquet files with fast append.
let new_tx = fast_append_action
+ .with_check_duplicate(false)
Review Comment:
I think this is a wrong test, we should remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
