Erigara commented on code in PR #1395:
URL: https://github.com/apache/iceberg-rust/pull/1395#discussion_r2116445984
##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -379,6 +364,7 @@ mod tests {
// Attempt to add the existing Parquet files with fast append.
let new_tx = fast_append_action
+ .with_check_duplicate(false)
Review Comment:
I'm not sure what was initial purpose of the test.
But it looks like to check ability of adding existing parquet files to the
table (physically existing not in table).
In which case adding `with_check_duplicate(false)` here is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
